|
Usually, when you die, the weapon you are holding when you die is the thing that is obtainable with a script. But I'm looking forward to all weapons to drop on death. This script I have shown doesn't seem to work. It's on a regular script and not LocalScript.
Crossing fingers that this doesn't get filtered:
local function onDied(character, p)
for i, v in pairs(p.Backpack:GetChildren()) do
if game.StarterPack:findFirstChild(v.Name) == nil and v.ClassName == "Tool" then
v.Parent = workspace
local h = v.Handle
h.Position = character.Torso.Position + Vector3.new(math.random(-5, 5), 3, math.random(-5, 5))
h.Velocity = Vector3.new(math.random(-25, 25), 3, math.random(-25, 25))
h.RotVelocity = Vector3.new(math.random(-25, 25), math.random(-5, 5), math.random(-25, 25))
end
end
end
local function onCharacterAdded(character, p)
character.Humanoid.Died:connect(function()
onDied(character, p)
end)
end
local function onPlayerAdded(player)
player.CharacterAdded:connect(function(ch) onCharacterAdded(ch, player) end)
end
game.Players.PlayerAdded:connect(onPlayerAdded)
I checked the Output and it didn't say anything. So, what does seem to be the problem with this script? |
|
|
I will say that the script is organized pretty messy. You can definitely clean it up while maintaining functionality, but lets try this first. What is the point of the first condition in this line?
if game.StarterPack:findFirstChild(v.Name) == nil and v.ClassName == "Tool" then
Try changing it to this for now:
if v:IsA("Tool") then
Which is similar to your second condition, I ignored the first condition for now. |
|
|
Huh... So that was the problem... Well, the thing works!
Thx, man! |
|
|
If you're still interested... I refactored your code a bit using anonymous functions to make it more compact. I also abstracted dropping the weapons into another function so that I can call it multiple times. I did this so that it is easier when checking for when the player has a tool equipped. Currently the code does not check for the tool that the player is currently holding. This should account for that:
game:GetService("Players").PlayerAdded:connect(function(player)
player.CharacterAdded:connect(function(character)
character:WaitForChild("Humanoid").Died:connect(function()
for i, v in pairs(player.Backpack:GetChildren()) do
if v:IsA("Tool") then
dropItem(character, v)
end
end
for i, v in pairs(character:GetChildren()) do
if v:IsA("Tool") then
dropItem(character, v)
break
end
end
end)
end)
end)
function dropItem(character, tool)
tool.Parent = workspace
local h = tool.Handle
h.Position = character.Torso.Position + Vector3.new(math.random(-5, 5), 3, math.random(-5, 5))
h.Velocity = Vector3.new(math.random(-25, 25), 3, math.random(-25, 25))
h.RotVelocity = Vector3.new(math.random(-25, 25), math.random(-5, 5), math.random(-25, 25))
end |
|
|
Dang, man. You actually took the time to do this.
Never actually thought of that way for the script. Let alone to know that the current held tool wasn't going to drop in the previous script.
This is really helpful! I appreciate the extra support. I didn't expect this. :3 |
|
|
No problem. Ask if you have any questions. |
|
|
Back again. This will probably be the last question.
Regarding this:
if v:IsA("Tool") then
It, of course, is meant for all tools. But what would the script look like if you die and your tools drop, but if the tool is a Cutlass, Lamp, or Molotov, it will not drop?
I'm looking forward to this because I don't want heavy weapon abuse from someone who's obtained so much of one weapon or lamp. |
|
deuJoin Date: 2007-01-07
Post Count: 150 |
``if (v:IsA("Tool")) then``
All weapons that you have is (most likely) a tool instance. It doesn't matter what the actual tool is, it just depends on if it's in the object.
|
|
deuJoin Date: 2007-01-07
Post Count: 150 |
*if it falls under the category.
|
|
|
You will need to explicitly state not to drop it. You can have a table of the names and loop through it to check. I further abstracted checking for a valid tool by verifying the name of the tool.
local doNotDrop = { "Cutlass", "Lamp", "Molotov" } --Add more here
game:GetService("Players").PlayerAdded:connect(function(player)
player.CharacterAdded:connect(function(character)
character:WaitForChild("Humanoid").Died:connect(function()
for i, v in pairs(player.Backpack:GetChildren()) do
if validDrop(v) then
dropItem(character, v)
end
end
for i, v in pairs(character:GetChildren()) do
if validDrop(v) then
dropItem(character, v)
break
end
end
end)
end)
end)
function dropItem(character, tool)
tool.Parent = workspace
local h = tool.Handle
h.Position = character.Torso.Position + Vector3.new(math.random(-5, 5), 3, math.random(-5, 5))
h.Velocity = Vector3.new(math.random(-25, 25), 3, math.random(-25, 25))
h.RotVelocity = Vector3.new(math.random(-25, 25), math.random(-5, 5), math.random(-25, 25))
end
function validDrop(item)
if not item:IsA("Tool") then return false
for _, x in pairs(doNotDrop) do
if item.Name == x then
return false
end
end
return true
end |
|
|
Thx, man! That appears to be everything!
Also, I gave you credit for the support you have give me on my game's description.
Thanks to you, I can finally be ready to release this game when the time is right! |
|